Skip to content

Commit

Permalink
fix: regression externalResouces should work globally, fix #1329
Browse files Browse the repository at this point in the history
- fixes issue #1329
- external resources can also be loaded globally in the forRoot and that regressed in previous PR #1320
  • Loading branch information
ghiscoding committed Dec 15, 2023
1 parent 0654550 commit 72fb260
Showing 1 changed file with 1 addition and 1 deletion.
Expand Up @@ -348,7 +348,7 @@ export class AngularSlickgridComponent<TData = any> implements AfterViewInit, On

// save resource refs to register before the grid options are merged and possibly deep copied
// since a deep copy of grid options would lose original resource refs but we want to keep them as singleton
this._registeredResources = this.gridOptions?.externalResources || [];
this._registeredResources = ({ ...this.forRootConfig, ...this.gridOptions } as GridOption)?.externalResources || [];

this.initialization(this._eventHandler);
this._isGridInitialized = true;
Expand Down

0 comments on commit 72fb260

Please sign in to comment.