fix(footer): custom footer should work anytime pagination is disabled

- it should work when pagination is disabled even when using BackendServiceApi
ghiscoding · Feb 3, 2020 · 7d9798a · 7d9798a
1 parent 4d5e65b
commit 7d9798a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/app/examples/grid-graphql-nopage.component.ts b/src/app/examples/grid-graphql-nopage.component.ts
@@ -141,6 +141,7 @@ export class GridGraphqlWithoutPaginationComponent implements OnInit {
       showPreHeaderPanel: true,
       preHeaderPanelHeight: 28,
       datasetIdPropertyName: 'code',
+      showCustomFooter: true, // display some metrics in the bottom custom footer
       backendServiceApi: {
         // use the GraphQL Service to build the query but use local (in memory) Filtering/Sorting strategies
         // the useLocalFiltering/useLocalSorting flags can be enabled independently

diff --git a/src/app/modules/angular-slickgrid/components/angular-slickgrid.component.ts b/src/app/modules/angular-slickgrid/components/angular-slickgrid.component.ts
@@ -959,7 +959,7 @@ export class AngularSlickgridComponent implements AfterViewInit, OnDestroy, OnIn
       }
 
       // we will display the custom footer only when there's no Pagination
-      if (!(this.gridOptions.backendServiceApi || this.gridOptions.enablePagination)) {
+      if (!this.gridOptions.enablePagination) {
         this.showCustomFooter = this.gridOptions.hasOwnProperty('showCustomFooter') ? this.gridOptions.showCustomFooter : false;
         this.customFooterOptions = this.gridOptions.customFooterOptions || {};
       }