Skip to content

Commit

Permalink
feat(filters): use offset left to calculate auto position (left/right)
Browse files Browse the repository at this point in the history
- use the offseft left position to properly calculate the available space instead of the scroll left position
  • Loading branch information
ghiscoding committed Dec 10, 2020
1 parent b0bc379 commit 9d79e2d
Showing 1 changed file with 4 additions and 10 deletions.
14 changes: 4 additions & 10 deletions src/assets/lib/multiple-select/multiple-select.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/**
* @author zhixin wen <wenzhixin2010@gmail.com>
* @version 1.3.9
* @version 1.3.10
*
* http://wenzhixin.net.cn/p/multiple-select/
*
Expand Down Expand Up @@ -631,9 +631,9 @@
var msDropHeight = this.$drop.outerHeight() || 0;
var msDropWidth = this.$drop.outerWidth() || 0;
var selectOffsetTop = this.$parent.offset().top;
var selectOffsetLeft = this.$parent.offset().left;
var selectParentWidth = this.$parent.width();
var spaceBottom = this.availableSpaceBottom();
var spaceLeft = this.availableSpaceLeft();
var spaceTop = this.availableSpaceTop();
var windowWidth = $(window).width();

Expand Down Expand Up @@ -662,8 +662,8 @@
}

// auto-adjust left/right position
if ((windowWidth - msDropWidth) < spaceLeft) {
var newLeftOffset = spaceLeft - (msDropWidth - selectParentWidth);
if ((windowWidth - msDropWidth) < selectOffsetLeft) {
var newLeftOffset = selectOffsetLeft - (msDropWidth - selectParentWidth);
this.$drop.offset({ left: newLeftOffset });
}

Expand Down Expand Up @@ -725,12 +725,6 @@
return windowHeight - (msDropOffsetTop - pageScroll);
},

availableSpaceLeft: function () {
var pageScrollLeft = $(window).scrollLeft() || 0;
var msDropOffsetLeft = this.$parent.offset().left;
return msDropOffsetLeft - pageScrollLeft;
},

availableSpaceTop: function () {
var pageScroll = $(window).scrollTop() || 0;
var msDropOffsetTop = this.$parent.offset().top;
Expand Down

0 comments on commit 9d79e2d

Please sign in to comment.