fix(observables): http cancellable Subject should be unsubscribed

ghiscoding · Apr 26, 2021 · c439324 · c439324
1 parent a84b489
commit c439324
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/src/app/modules/angular-slickgrid/services/filter.service.ts b/src/app/modules/angular-slickgrid/services/filter.service.ts
@@ -100,6 +100,7 @@ export class FilterService {
     }
     if (isObservable(this.httpCancelRequests$)) {
       this.httpCancelRequests$.next(); // this cancels any pending http requests
+      this.httpCancelRequests$.unsubscribe();
     }
     this.disposeColumnFilters();
     this._onSearchChange = null;

diff --git a/src/app/modules/angular-slickgrid/services/sort.service.ts b/src/app/modules/angular-slickgrid/services/sort.service.ts
@@ -187,6 +187,7 @@ export class SortService {
     }
     if (isObservable(this.httpCancelRequests$)) {
       this.httpCancelRequests$.next(); // this cancels any pending http requests
+      this.httpCancelRequests$.unsubscribe();
     }
   }