Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header Grouping not showed when frozenColumn are setted #290

Closed
ybarbaria opened this issue Sep 21, 2019 · 10 comments
Closed

Header Grouping not showed when frozenColumn are setted #290

ybarbaria opened this issue Sep 21, 2019 · 10 comments

Comments

@ybarbaria
Copy link

Hi,

I am trying to set some header group, some of my cols are frozen some not. I try to add a header grouping on the col not frozen and doesn't appear.
I tried to show a header group on the frozen cols and this one appear but still not on the cols not frozen.

So i took your code from the demo page and I created a stackblitz, will be easy to show you what happened :)

https://stackblitz.com/edit/angular-slickgrid-headergroup

If you take off the param :
frozenColumn: 1,
All the header-group missing will appear.

Let me know if you have any idea for fix that.
Thanks for your job by the way , your lib is great !

Cheers

@ghiscoding
Copy link
Owner

Are you talking about this kind of Example from the core lib? If so this was fixed recently on the core lib in this PR #429 and I did not upgrade to latest version of SlickGrid yet so it won't work in Angular-Slickgrid until I upgrade

@ybarbaria
Copy link
Author

Exactly what I am looking for ! Thanks for you response! I will wait until you release the new version.

@ghiscoding
Copy link
Owner

Latest version includes the core lib fix, please upgrade to Angular-Slickgrid version 2.11.0.

Also note that it probably won't work out of the box without some code change, I see some differences in the new SlickGrid example on this line.

@ybarbaria
Copy link
Author

Thanks @ghiscoding ! I will look at that !

@mad786
Copy link

mad786 commented Oct 10, 2019

@ybarbaria Any update on that feature. Have you been able to get the Header Grouping on the right panel of unfrozen columns. In my case the issue still persists.

Thanks.

@ybarbaria
Copy link
Author

@mad786 sorry didn't have time to try the last version. Will do this weekend.

@mad786
Copy link

mad786 commented Oct 10, 2019

@ybarbaria Ok. Thanks. Do let me know if it works.
@ghiscoding Can you please take a look into this if possible.

Thanks in advance.

@mad786
Copy link

mad786 commented Oct 14, 2019

@ghiscoding Can we reopen this issue for angular-slickgrid?

@ghiscoding
Copy link
Owner

Also note that it probably won't work out of the box without some code change, I see some differences in the new SlickGrid example on this line.

ghiscoding added a commit that referenced this issue Oct 21, 2019
…rozen-grid

feat(frozen): fix header grouping grid with frozen columns, fixes #290
@ghiscoding
Copy link
Owner

ghiscoding commented Oct 21, 2019

I pushed a commit to update the example and the service with pinned (frozen) columns. The latest version 2.12.2 has the fix, cheers ⭐️

@mad786
I suggest you to read about the meaning of Open Source Community, in short, if you want help then you should help back. Contributions are welcome and beneficial to this project. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants