Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter combined with sort makes rows disappear #310

Closed
RajeshGunasundaram opened this issue Oct 10, 2019 · 3 comments · Fixed by #313
Closed

Filter combined with sort makes rows disappear #310

RajeshGunasundaram opened this issue Oct 10, 2019 · 3 comments · Fixed by #313
Labels

Comments

@RajeshGunasundaram
Copy link

RajeshGunasundaram commented Oct 10, 2019

I'm submitting a Bug report

Your Environment

Software Version(s)
Angular 7
Angular-Slickgrid 2.4.2
TypeScript 3.1.3
Operating System WIndows 10
NPM/Node/Yarn 10.15

Context

Expected Behavior

Sorting should work even after hiding the filtered column

Current Behavior

Enter a filter value in any of the column in the grid
Remove that filtered column from the grid
Click on any other column in the grid to sort
All rows in the grid disappear

@ghiscoding ghiscoding added the bug label Oct 10, 2019
@ghiscoding
Copy link
Owner

I can reproduce, I think this might be fixable by calling a clear filter internally before hiding the column. That seems to work from my early testing on the demo site anyway

@RajeshGunasundaram
Copy link
Author

I can reproduce, I think this might be fixable by calling a clear filter internally before hiding the column. That seems to work from my early testing on the demo site anyway

I don't want to clear the filter. I want to keep the filter and do sorting after hiding the filtered column

@ghiscoding
Copy link
Owner

This was fixed and released under the new version 2.12.0, please make sure to read the entire announcement as there is an important change, even though small, to make.

Also please up vote ⭐️ if you have not yet and of course if you like the lib. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants