Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluded menu item is still displayed in Bootstrap4 #321

Closed
whtan98 opened this issue Oct 22, 2019 · 3 comments
Closed

Excluded menu item is still displayed in Bootstrap4 #321

whtan98 opened this issue Oct 22, 2019 · 3 comments
Labels

Comments

@whtan98
Copy link
Contributor

whtan98 commented Oct 22, 2019

I'm submitting a Bug report

It seems that "hidden" class is no longer available in Bootstrap 4.
This causes those hidden menu items in GridMenu become visible.

https://ghiscoding.github.io/angular-slickgrid-demos/#/editor

Your Environment

Software Version(s)
Angular 8
Angular-Slickgrid 2.12

Current Behavior

image

@ghiscoding
Copy link
Owner

ghiscoding commented Oct 22, 2019

Good catch, I wasn't aware that this class was removed in BS4, we still use BS3 for our project so.
You can use the following SASS style (or convert it to CSS), I tried it in the BS4 demo and it works.

.slick-gridmenu-list {
  li.hidden {
    display: none;
  }
}

I recommend you do this change on your local, because I'm not planning on releasing a new version just for this (I released yesterday).

EDIT

Actually I forgot the Column Picker, you need to include both (unless you want to make a hidden styling that is generic). The updated version to cover both would be

.slick-columnpicker-list,
.slick-gridmenu-list {
  li.hidden {
    display: none;
  }
}

@ghiscoding ghiscoding added the bug label Oct 22, 2019
ghiscoding added a commit to ghiscoding/aurelia-slickgrid that referenced this issue Oct 23, 2019
- ref Angular-Slickgrid issue [#321](ghiscoding/Angular-Slickgrid#321)
- BS4 removed the "hidden" class making hidden menu showing in both ColumnPicker & GridMenu
@whtan98
Copy link
Contributor Author

whtan98 commented Oct 24, 2019

Many thanks for prompt response !

@ghiscoding
Copy link
Owner

This was pushed under latest version 2.12.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants