Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(odata): no single quote escape required for IN operator for non-string column #341

Merged
merged 2 commits into from
Nov 21, 2019
Merged

fix(odata): no single quote escape required for IN operator for non-string column #341

merged 2 commits into from
Nov 21, 2019

Conversation

whtan98
Copy link
Contributor

@whtan98 whtan98 commented Nov 21, 2019

See #340

@codecov
Copy link

codecov bot commented Nov 21, 2019 •
edited

Codecov Report

Merging #341 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #341      +/-   ##
==========================================
+ Coverage   99.81%   99.81%   +0.01%     
==========================================
  Files         138      138              
  Lines        8157     8159       +2     
  Branches     2777     2778       +1     
==========================================
+ Hits         8141     8143       +2     
  Misses         16       16
Impacted Files Coverage Δ
...s/angular-slickgrid/services/grid-odata.service.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6952a00...9491ab1. Read the comment docs.

@ghiscoding
Copy link
Owner

Thanks for the PR, would it be possible to add a unit test for this new condition?

@ghiscoding ghiscoding changed the title No single quote escape is required for OData IN operator for non-string column fix(odata): no single quote escape required for IN operator for non-string column Nov 21, 2019
@whtan98
Copy link
Contributor Author

whtan98 commented Nov 21, 2019

Thanks for the PR, would it be possible to add a unit test for this new condition?

Yes, if you don't mind that it may take longer, as this is my 1st JEST unit test

@whtan98
Copy link
Contributor Author

whtan98 commented Nov 21, 2019

Unit test done.

@ghiscoding ghiscoding merged commit abb2419 into ghiscoding:master Nov 21, 2019
@ghiscoding
Copy link
Owner

Awesome thanks a lot, it's all green now 😄

@ghiscoding ghiscoding mentioned this pull request Nov 21, 2019
Closed
ghiscoding-SE pushed a commit that referenced this pull request May 17, 2021
@ghiscoding
fix(resizer): remove delay to call resize by content to avoid flickering
ea4a196 
- loading of Columns Grid Presets should only be done once (before resizing) and loading Filters Grid Presets could be done one or more times, so to fix this I have separated `loadPresetsWhenDatasetInitialized` into 2 new methods and made sure to call the columns grid preset only once.
- this issue was identified while porting the previous PR #341 into Angular-Slickgrid
@ghiscoding ghiscoding mentioned this pull request May 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@whtan98 @ghiscoding