Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filter): string filter should also work when using Contains #427

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

ghiscoding
Copy link
Owner

  • when using OperatorType.empty or OperatorType.contains, they should do a comparison of passing when item contains the substring of search term

- when using OperatorType.empty or OperatorType.contains, they should do a comparison of passing when item contains the substring of search term
@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #427 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #427    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          141       141            
  Lines         8855      8856     +1     
  Branches      3059      2932   -127     
==========================================
+ Hits          8855      8856     +1     
Impacted Files Coverage Δ
...ickgrid/filter-conditions/stringFilterCondition.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bca1f0b...3185373. Read the comment docs.

@ghiscoding ghiscoding merged commit 2c0765b into master Apr 3, 2020
@ghiscoding ghiscoding deleted the bugfix/filter-string-contains branch April 3, 2020 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants