Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(export): add grouped header title (from pre-header) into exports #436

Merged
merged 2 commits into from
Apr 30, 2020

Conversation

ghiscoding
Copy link
Owner

  • when having Grouped Header Titles (in pre-header), those were not showing in the export, now they do

- when having Grouped Header Titles (in pre-header), those were not showing in the export, now they do
@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #436 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #436   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          141       141           
  Lines         8899      8956   +57     
  Branches      3075      3099   +24     
=========================================
+ Hits          8899      8956   +57     
Impacted Files Coverage Δ
...p/modules/angular-slickgrid/global-grid-options.ts 100.00% <ø> (ø)
.../angular-slickgrid/services/excelExport.service.ts 100.00% <100.00%> (ø)
...dules/angular-slickgrid/services/export.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a746c2d...bfcdd11. Read the comment docs.

@ghiscoding ghiscoding merged commit a315f85 into master Apr 30, 2020
@ghiscoding ghiscoding deleted the bugfix/export-with-grouped-header-titles branch April 30, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants