Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gridMenu): command "Toggle Filter Row" header row #466

Merged
merged 1 commit into from
May 21, 2020

Conversation

ghiscoding
Copy link
Owner

previous PR #448 caused a new and small issue, were the header row is being shown when changing locale even when there are no Filters.

previous PR #448 caused a new and small issue, were the header row is being shown when changing locale even when there are no Filters.
@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

Merging #466 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #466    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          148       148            
  Lines         9534      9534            
  Branches      3314      3177   -137     
==========================================
  Hits          9534      9534            
Impacted Files Coverage Δ
...lickgrid/components/angular-slickgrid.component.ts 100.00% <100.00%> (ø)
...r-slickgrid/services/groupingAndColspan.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 528abf5...f7ce623. Read the comment docs.

@ghiscoding ghiscoding merged commit 4858794 into master May 21, 2020
@ghiscoding ghiscoding deleted the bugfix/header-row-translate-filters branch May 21, 2020 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants