Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add missing use of custom datasetIdPropertyName #476

Merged
merged 2 commits into from
May 28, 2020

Conversation

ghiscoding
Copy link
Owner

  • do a solution search and add "datasetIdPropertyName" everywhere that it was missing

- do a solution search and add "datasetIdPropertyName" everywhere that it was missing
@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #476 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #476   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          148       148           
  Lines         9535      9542    +7     
  Branches      3178      3185    +7     
=========================================
+ Hits          9535      9542    +7     
Impacted Files Coverage Δ
...dules/angular-slickgrid/editors/dualInputEditor.ts 100.00% <100.00%> (ø)
...lar-slickgrid/extensions/rowDetailViewExtension.ts 100.00% <100.00%> (ø)
...dules/angular-slickgrid/services/filter.service.ts 100.00% <100.00%> (ø)
...modules/angular-slickgrid/services/grid.service.ts 100.00% <100.00%> (ø)
...les/angular-slickgrid/services/treeData.service.ts 100.00% <100.00%> (ø)
...pp/modules/angular-slickgrid/services/utilities.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aa4f97...c4a1358. Read the comment docs.

@ghiscoding ghiscoding merged commit 9be8fbf into master May 28, 2020
@ghiscoding ghiscoding deleted the bugfix/add-custom-dataview-id-everywhere branch May 28, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants