Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filter): recreate filter when toggling header row, fixes #493 #496

Merged
merged 3 commits into from
Jun 17, 2020

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Jun 16, 2020

@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #496 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #496    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          148       148            
  Lines         9545      9548     +3     
  Branches      3187      3323   +136     
==========================================
+ Hits          9545      9548     +3     
Impacted Files Coverage Δ
...lickgrid/components/angular-slickgrid.component.ts 100.00% <100.00%> (ø)
.../angular-slickgrid/extensions/gridMenuExtension.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1550d9d...7cf991e. Read the comment docs.

@ghiscoding ghiscoding merged commit 56d74ae into master Jun 17, 2020
@ghiscoding ghiscoding deleted the bugfix/filter-toggle-header-row branch June 17, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toggle filter view showing as blank space after reorder the columns in Angular SlickGrid
2 participants