Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(header): re-create header grouping title after changing picker cols #502

Merged
merged 2 commits into from
Jun 18, 2020

Conversation

ghiscoding
Copy link
Owner

  • after hiding/showing columns from ColumnPicker/GridMenu we need to re-create the header grouping titles

- after hiding/showing columns from ColumnPicker/GridMenu we need to re-create the header grouping titles
@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #502 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #502    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          148       148            
  Lines         9556      9564     +8     
  Branches      3192      3330   +138     
==========================================
+ Hits          9556      9564     +8     
Impacted Files Coverage Δ
...r-slickgrid/services/groupingAndColspan.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f7b569...317a885. Read the comment docs.

@ghiscoding ghiscoding changed the title fix(header): re-create header grouping title after changing picker cols WIP - fix(header): re-create header grouping title after changing picker cols Jun 18, 2020
@ghiscoding ghiscoding changed the title WIP - fix(header): re-create header grouping title after changing picker cols fix(header): re-create header grouping title after changing picker cols Jun 18, 2020
@ghiscoding ghiscoding merged commit f03c6f9 into master Jun 18, 2020
@ghiscoding ghiscoding deleted the bugfix/header-grouping-titles-with-picker branch June 18, 2020 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants