Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(presets): compound filters operator not working correctly w/presets #507

Merged
merged 2 commits into from
Jun 25, 2020

Conversation

ghiscoding
Copy link
Owner

  • grid presets should work with short/long operator names, basically StartsWith/EndsWith were not working correctly while a*/*z were working correctly, both options should work

- grid presets should work with short/long operator names, basically StartsWith/EndsWith were not working correctly while a*/*z were working correctly, both options should work
@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #507 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #507   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          148       148           
  Lines         9566      9570    +4     
  Branches      3332      3333    +1     
=========================================
+ Hits          9566      9570    +4     
Impacted Files Coverage Δ
...es/angular-slickgrid/filters/compoundDateFilter.ts 100.00% <100.00%> (ø)
...s/angular-slickgrid/filters/compoundInputFilter.ts 100.00% <100.00%> (ø)
.../angular-slickgrid/filters/compoundSliderFilter.ts 100.00% <100.00%> (ø)
...s/angular-slickgrid/services/grid-odata.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5284ada...6c923ad. Read the comment docs.

@ghiscoding ghiscoding merged commit f7b5270 into master Jun 25, 2020
@ghiscoding ghiscoding deleted the bugfix/presets-compound-filter-operator branch June 25, 2020 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants