Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): float validator should accept decimal even without 0 suffix #510

Merged
merged 2 commits into from
Jun 25, 2020

Conversation

ghiscoding
Copy link
Owner

  • basically 0.3 and .3 should be both accepted, the second one wasn't and this PR fixes it

@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #510 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #510    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          148       148            
  Lines         9586      9586            
  Branches      3206      3342   +136     
==========================================
  Hits          9586      9586            
Impacted Files Coverage Δ
...gular-slickgrid/editorValidators/floatValidator.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5898c18...410cf5f. Read the comment docs.

@ghiscoding ghiscoding merged commit 04b4465 into master Jun 25, 2020
@ghiscoding ghiscoding deleted the bugfix/float-validator branch June 25, 2020 17:31
@meta-akshita-agrawal
Copy link

Hi, @ghiscoding is this fix released?

@ghiscoding
Copy link
Owner Author

ghiscoding commented Jun 26, 2020

no, I'm waiting for a SlickGrid core library version before I can release mine.
It might come next week or later, be patient

@ghiscoding
Copy link
Owner Author

@meta-akshita-agrawal
This is now fixed in latest version 2.19.x.

Please upvote ⭐ if you haven't already.
Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants