Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editors): add min/max length options to text editors #542

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

ghiscoding
Copy link
Owner

  • add a text length counter (currentTextLength/maxLength) to the LongText Editor
  • the new minLenght, maxLength options can be used by the following Editors (autoComplete, longText, text)
  • also flip the position of the Cancel/Save buttons, Cancel should be on the left and Save on the right

- add a text length counter (currentTextLength/maxLength) to the LongText Editor
- the new `minLenght`, `maxLength` options can be used by the following Editors (autoComplete, longText, text)
- also flip the position of the Cancel/Save buttons, Cancel should be on the left and Save on the right
@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #542 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #542    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          148       148            
  Lines         9663      9708    +45     
  Branches      3258      3410   +152     
==========================================
+ Hits          9663      9708    +45     
Impacted Files Coverage Δ
...lar-slickgrid/editorValidators/integerValidator.ts 100.00% <ø> (ø)
...es/angular-slickgrid/editors/autoCompleteEditor.ts 100.00% <ø> (ø)
...pp/modules/angular-slickgrid/editors/textEditor.ts 100.00% <ø> (ø)
src/app/modules/angular-slickgrid/constants.ts 100.00% <100.00%> (ø)
...ngular-slickgrid/editorValidators/textValidator.ts 100.00% <100.00%> (ø)
...odules/angular-slickgrid/editors/longTextEditor.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34ed648...674225f. Read the comment docs.

@ghiscoding ghiscoding merged commit cc17d36 into master Jul 29, 2020
@ghiscoding ghiscoding deleted the feat/editor-min-max-length branch July 29, 2020 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants