Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate singleSelect editable is not firing onValidationError(e, args) #571

Closed
ranjithitwizard opened this issue Sep 7, 2020 · 1 comment · Fixed by #574
Closed

Validate singleSelect editable is not firing onValidationError(e, args) #571

ranjithitwizard opened this issue Sep 7, 2020 · 1 comment · Fixed by #574
Labels
bug

Comments

@ranjithitwizard
Copy link

I'm submitting a Bug report

Your Environment

Software Version(s)
Angular 9.1.1
Angular-Slickgrid 2.18.7
TypeScript 3.8.3

Describe the Bug

Editors.singleSelect cell validation is not firing the onValidationError(e,args) after cell edit completes.

Steps to Reproduce

  1. create a column with inline editable as Editor.singleSelect
  2. Define custom validator function to validate the value after cell edit
  3. OnValidationError is not firing if any error after edit completes

Expected Behavior

onValidationError should taken place

Current Behavior

Error handling is not prompting the alert message

Possible Solution

Code Sample

onValidationError(e, args) {
     alert(args.validationResults.msg);
}
@ghiscoding ghiscoding added the bug label Sep 7, 2020
@ghiscoding ghiscoding mentioned this issue Sep 8, 2020
Merged
ghiscoding added a commit that referenced this issue Sep 8, 2020
@ghiscoding
fix(editors): all Editors should call commitChanges even when invalid, …
fd052d1 
…fixes #571 (#574)

* fix(editors): fix all Editors custom validators with invalid results

* fix(editors): all Editors should call commitChanges even when invalid
- for the Editor validators to work properly it needs to call the commitChanges() at all time even when potentially invalid or value is unchanged so that the validator can be executed at all time
@ghiscoding
Copy link
Owner

This is now fixed and released under the new version 2.21.3

Please upvote ⭐ if you haven't already.
Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@ghiscoding @ranjithitwizard