Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(styling): add description to Compound Filter Operators #588

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Sep 28, 2020

  • also change Compound Filter styling
  • the new translations required are the following
{
      CONTAINS: 'Contains',
      EQUALS: 'Equals',
      ENDS_WITH: 'Ends With',
      STARTS_WITH: 'Starts With',
      EQUAL_TO: 'Equal to',
      LESS_THAN: 'Less than',
      LESS_THAN_OR_EQUAL_TO: 'Less than or equal to',
      GREATER_THAN: 'Greater than',
      GREATER_THAN_OR_EQUAL_TO: 'Greater than or equal to',
      NOT_EQUAL_TO: 'Not equal to',
}

image

- also change Compound Filter styling
@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #588 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #588   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          148       149    +1     
  Lines         9831      9854   +23     
  Branches      3472      3479    +7     
=========================================
+ Hits          9831      9854   +23     
Impacted Files Coverage Δ
src/app/modules/angular-slickgrid/constants.ts 100.00% <ø> (ø)
...es/angular-slickgrid/editors/autoCompleteEditor.ts 100.00% <100.00%> (ø)
...es/angular-slickgrid/filters/compoundDateFilter.ts 100.00% <100.00%> (ø)
...s/angular-slickgrid/filters/compoundInputFilter.ts 100.00% <100.00%> (ø)
.../angular-slickgrid/filters/compoundSliderFilter.ts 100.00% <100.00%> (ø)
...dules/angular-slickgrid/filters/filterUtilities.ts 100.00% <100.00%> (ø)
...pp/modules/angular-slickgrid/services/utilities.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18289d3...874cdfc. Read the comment docs.

@ghiscoding ghiscoding merged commit 56588d1 into master Sep 28, 2020
@ghiscoding ghiscoding deleted the feat/restyle-compound-filters branch September 28, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant