Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editors): add blank entry on Select Editor should happen once #591

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

ghiscoding
Copy link
Owner

  • the problem was noticeable after opening/closing the select dropdown multiple times

- the problem was noticeable after opening/closing the select dropdown multiple times
@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #591 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #591    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          149       149            
  Lines         9917      9917            
  Branches      3499      3353   -146     
==========================================
  Hits          9917      9917            
Impacted Files Coverage Δ
.../modules/angular-slickgrid/editors/selectEditor.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56588d1...eeb609d. Read the comment docs.

@ghiscoding ghiscoding merged commit f847e43 into master Sep 30, 2020
@ghiscoding ghiscoding deleted the bugfix/select-editor-blank-entry branch September 30, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant