Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filters): tree data presets caused regression in any grid w/presets #597

Merged
merged 2 commits into from
Oct 2, 2020

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Oct 2, 2020

  • a regression was observer when using GridState/GridPresets with Local Storage, whenever clearing a Filter, it would put back the preset filter.

@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #597 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #597   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          149       149           
  Lines         9945      9946    +1     
  Branches      3369      3370    +1     
=========================================
+ Hits          9945      9946    +1     
Impacted Files Coverage Δ
...lickgrid/components/angular-slickgrid.component.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5db78c2...7eefb43. Read the comment docs.

@ghiscoding ghiscoding merged commit 74d611d into master Oct 2, 2020
@ghiscoding ghiscoding deleted the bugfix/filter-grid-presets-regression branch October 2, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants