Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): update project lib to Angular 8 with newer ng-packagr #617

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Oct 29, 2020

basically had no choice but to update to a newer Angular because latest Babel (an indirect lib) doesn't work with TypeScript below 3.5.x

TODOs

  • run a build and test with Angular-Slickgrid-Demos

@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #617 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #617   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          149       149           
  Lines         9974      9974           
  Branches      3528      3528           
=========================================
  Hits          9974      9974           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a613d4...1547dcd. Read the comment docs.

@ghiscoding ghiscoding changed the title feat(core): update project lib to Angular 8 with newer ng-packagr WIP - feat(core): update project lib to Angular 8 with newer ng-packagr Oct 29, 2020
@ghiscoding ghiscoding changed the title WIP - feat(core): update project lib to Angular 8 with newer ng-packagr feat(core): update project lib to Angular 8 with newer ng-packagr Nov 2, 2020
@ghiscoding ghiscoding merged commit edae737 into master Nov 2, 2020
@ghiscoding ghiscoding deleted the feat/angular8-ng-packagr branch November 2, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant