Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): mem leaks w/orphan DOM elements when disposing, fixes #625 #626

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Nov 6, 2020

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #626 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #626   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          149       149           
  Lines         9987     10048   +61     
  Branches      3530      3538    +8     
=========================================
+ Hits          9987     10048   +61     
Impacted Files Coverage Δ
...lickgrid/components/angular-slickgrid.component.ts 100.00% <100.00%> (ø)
...es/angular-slickgrid/editors/autoCompleteEditor.ts 100.00% <100.00%> (ø)
...odules/angular-slickgrid/editors/checkboxEditor.ts 100.00% <100.00%> (ø)
...pp/modules/angular-slickgrid/editors/dateEditor.ts 100.00% <100.00%> (ø)
...p/modules/angular-slickgrid/editors/floatEditor.ts 100.00% <100.00%> (ø)
...modules/angular-slickgrid/editors/integerEditor.ts 100.00% <100.00%> (ø)
...odules/angular-slickgrid/editors/longTextEditor.ts 100.00% <100.00%> (ø)
.../modules/angular-slickgrid/editors/selectEditor.ts 100.00% <100.00%> (ø)
.../modules/angular-slickgrid/editors/sliderEditor.ts 100.00% <100.00%> (ø)
...pp/modules/angular-slickgrid/editors/textEditor.ts 100.00% <100.00%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6153fe4...fd0cb5b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant