Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): properly dispose plugins to avoid detached DOM elements #628

Merged
merged 2 commits into from
Nov 9, 2020

Conversation

ghiscoding
Copy link
Owner

3rd pass to fix #625

@codecov
Copy link

codecov bot commented Nov 7, 2020

Codecov Report

Merging #628 (c3fcd67) into master (a9f7027) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #628    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          149       149            
  Lines        10062     10075    +13     
  Branches      3398      3548   +150     
==========================================
+ Hits         10062     10075    +13     
Impacted Files Coverage Δ
...ules/angular-slickgrid/services/resizer.service.ts 100.00% <ø> (ø)
...lickgrid/components/angular-slickgrid.component.ts 100.00% <100.00%> (ø)
...es/angular-slickgrid/editors/autoCompleteEditor.ts 100.00% <100.00%> (ø)
...dules/angular-slickgrid/editors/dualInputEditor.ts 100.00% <100.00%> (ø)
...p/modules/angular-slickgrid/editors/floatEditor.ts 100.00% <100.00%> (ø)
...modules/angular-slickgrid/editors/integerEditor.ts 100.00% <100.00%> (ø)
.../modules/angular-slickgrid/editors/sliderEditor.ts 100.00% <100.00%> (ø)
...pp/modules/angular-slickgrid/editors/textEditor.ts 100.00% <100.00%> (ø)
...rid/extensions/cellExternalCopyManagerExtension.ts 100.00% <100.00%> (ø)
...-slickgrid/extensions/checkboxSelectorExtension.ts 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9f7027...c3fcd67. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular-Slickgrid Leaks Detached DOM Elements & Cause Slowness with Input KeyStroke Typing
1 participant