Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extensions): CellExternalCopyBuffer onKeyDown event leak, fix #635 #636

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Nov 20, 2020

fixes #635

@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #636 (c41254d) into master (501908a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #636   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          153       154    +1     
  Lines        10281     10294   +13     
  Branches      3614      3615    +1     
=========================================
+ Hits         10281     10294   +13     
Impacted Files Coverage Δ
.../app/modules/angular-slickgrid/formatters/index.ts 100.00% <ø> (ø)
...dules/angular-slickgrid/editors/dualInputEditor.ts 100.00% <100.00%> (ø)
...rid/extensions/cellExternalCopyManagerExtension.ts 100.00% <100.00%> (ø)
...angular-slickgrid/services/bindingEvent.service.ts 100.00% <100.00%> (ø)
...rc/app/modules/angular-slickgrid/services/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 501908a...c41254d. Read the comment docs.

@ghiscoding ghiscoding merged commit 9ce8326 into master Nov 20, 2020
@ghiscoding ghiscoding deleted the bugfix/cell-external-copy-plugin-remove-event branch November 20, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant