Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Empty Data" warning message when grid is empty(not work autoHeight: true) #671

Closed
denhaandrei opened this issue Jan 12, 2021 · 2 comments · Fixed by #672
Closed

Add "Empty Data" warning message when grid is empty(not work autoHeight: true) #671

denhaandrei opened this issue Jan 12, 2021 · 2 comments · Fixed by #672

Comments

@denhaandrei
Copy link

denhaandrei commented Jan 12, 2021

I'm submitting a Bug report

By the bug: #670
By the task: #631

Your Environment

Software Version(s)
Angular 8.2.14
Angular-Slickgrid 2.25.0
TypeScript 3.5.3

Describe the Bug

The 'enableEmptyDataWarningMessage' not work, when autoHeight set true.

Steps to Reproduce

use next setup for your grid:

datasetIdPropertyName: 'id',
        enableColumnReorder: false,
        multiColumnSort: false,
        alwaysShowVerticalScroll: false,
        enableAutoTooltip: true,
        autoHeight: true,
        autoResize: {
            containerId: 'containerId',
            calculateAvailableSizeBy: 'container'
        },
        enablePagination: false,
        enableEmptyDataWarningMessage: true,
        emptyDataWarning: {
            message: 'No Records Found'
        }

Expected Behavior

Message 'No Records Found' showing when grid is empty.

Current Behavior

Message 'No Records Found' not showing when grid is empty.

Possible Solution

for class="grid-canvas grid-canvas-top grid-canvas-left" - remove height="0"
for class="slick-pane slick-pane-top slick-pane-left" - add height="70"(now 55)

Code Sample

for class="grid-canvas grid-canvas-top grid-canvas-left" - remove height="0"
for class="slick-pane slick-pane-top slick-pane-left" - add height="70"(now 55)

@denhaandrei
Copy link
Author

Thanks for your quick response.
I`m apply your changes on my environment and this is not work.

Im add some fixes and test it. Its work for me(one row, multy row, huge grid).
how to fix (use minHeight when use height - render is not always call)
also remove min-height settings when message is not showing
Also, i`m add refresh warning after grid showing on form because this.grid in warning component return undefined
Please, review files and include this changes.
slick-empty-warning.component.txt(#672 attached)
angular-slickgrid.component.txt(#672 attached)

ghiscoding added a commit that referenced this issue Jan 19, 2021
fix(comp): empty data warning should work with autoheight grid, fix #671
@ghiscoding
Copy link
Owner

@denhaandrei
This is now released in the version 2.25.1

Cheers ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants