Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editors): change all private keyword to protected for extensability #680

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

ghiscoding
Copy link
Owner

  • also changed all services to readonly

@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #680 (5f9148b) into master (7b95401) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #680   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          157       157           
  Lines        10458     10458           
  Branches      3515      3515           
=========================================
  Hits         10458     10458           
Impacted Files Coverage Δ
...es/angular-slickgrid/editors/autoCompleteEditor.ts 100.00% <100.00%> (ø)
...odules/angular-slickgrid/editors/checkboxEditor.ts 100.00% <100.00%> (ø)
...pp/modules/angular-slickgrid/editors/dateEditor.ts 100.00% <100.00%> (ø)
...dules/angular-slickgrid/editors/dualInputEditor.ts 100.00% <100.00%> (ø)
...p/modules/angular-slickgrid/editors/floatEditor.ts 100.00% <100.00%> (ø)
...modules/angular-slickgrid/editors/integerEditor.ts 100.00% <100.00%> (ø)
...odules/angular-slickgrid/editors/longTextEditor.ts 100.00% <100.00%> (ø)
.../modules/angular-slickgrid/editors/sliderEditor.ts 100.00% <100.00%> (ø)
...pp/modules/angular-slickgrid/editors/textEditor.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b95401...5f9148b. Read the comment docs.

@ghiscoding ghiscoding merged commit 029a90c into master Jan 21, 2021
@ghiscoding ghiscoding deleted the feat/extendable-editors branch January 21, 2021 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant