Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): enable tsconfig strict mode tsconfig, fixes #675 #702

Merged
merged 2 commits into from
Feb 24, 2021

Conversation

ghiscoding
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #702 (718fbcb) into master (61e6599) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #702   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          159       159           
  Lines        10595     10611   +16     
  Branches      3728      3754   +26     
=========================================
+ Hits         10595     10611   +16     
Impacted Files Coverage Δ
...odules/angular-slickgrid/editors/longTextEditor.ts 100.00% <ø> (ø)
...ular-slickgrid/extensions/columnPickerExtension.ts 100.00% <ø> (ø)
...slickgrid/extensions/draggableGroupingExtension.ts 100.00% <ø> (ø)
...ular-slickgrid/extensions/headerButtonExtension.ts 100.00% <ø> (ø)
.../angular-slickgrid/services/graphqlQueryBuilder.ts 100.00% <ø> (ø)
...es/angular-slickgrid/services/gridEvent.service.ts 100.00% <ø> (ø)
...dules/angular-slickgrid/sorters/sorterUtilities.ts 100.00% <ø> (ø)
...les/angular-slickgrid/aggregators/avgAggregator.ts 100.00% <100.00%> (ø)
...les/angular-slickgrid/aggregators/maxAggregator.ts 100.00% <100.00%> (ø)
...les/angular-slickgrid/aggregators/minAggregator.ts 100.00% <100.00%> (ø)
... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 269f1e9...718fbcb. Read the comment docs.

@ghiscoding ghiscoding merged commit 7219249 into master Feb 24, 2021
@ghiscoding ghiscoding deleted the feat/enable-strictness branch February 24, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant