Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins): do not recreate header button plugin after re-render #706

Merged
merged 2 commits into from
Mar 1, 2021

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Mar 1, 2021

  • there is no need to recreate the header button because if we do that then we lose previous ref and onCommand stops working

- when using 2 dots notation (`2..5`), we should use `defaultFilterRangeOperator` when none is provided and/or isn't a range operator
- there is no need to recreate the header button because if we do that then we lose previous ref and onCommand stops working
@ghiscoding ghiscoding changed the title Bugfix/range filter default operator fix(plugins): do not recreate header button plugin after re-render Mar 1, 2021
@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #706 (58c6a7d) into master (7219249) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #706   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          159       159           
  Lines        10611     10615    +4     
  Branches      3754      3755    +1     
=========================================
+ Hits         10611     10615    +4     
Impacted Files Coverage Δ
...es/angular-slickgrid/services/extension.service.ts 100.00% <ø> (ø)
...dules/angular-slickgrid/services/filter.service.ts 100.00% <ø> (ø)
...slickgrid/filter-conditions/dateFilterCondition.ts 100.00% <100.00%> (ø)
...ickgrid/filter-conditions/numberFilterCondition.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7219249...58c6a7d. Read the comment docs.

@ghiscoding ghiscoding merged commit da62a48 into master Mar 1, 2021
@ghiscoding ghiscoding deleted the bugfix/range-filter-default-operator branch March 1, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant