Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pinning): reordering cols position freezing cols shouldn't affect #708

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Mar 2, 2021

  • the steps to reproduce the issue was to create a grid with frozenColumn in the grid options, then change column position (cols reordering) and finally open header menu and freeze any of the column and the bug was that it was going back to original positions while it should keep new positions and just add new freeze column

XMqeZnN

- the steps to reproduce the issue was to create a grid with `frozenColumn` in the grid options, then change column position (cols reordering) and finally open header menu and freeze any of the column and the bug was that it was going back to original positions while it should keep new positions and just add new freeze column
@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #708 (235c664) into master (2d686ff) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #708   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          159       159           
  Lines        10615     10624    +9     
  Branches      3755      3755           
=========================================
+ Hits         10615     10624    +9     
Impacted Files Coverage Δ
...lickgrid/components/angular-slickgrid.component.ts 100.00% <100.00%> (ø)
...ngular-slickgrid/extensions/headerMenuExtension.ts 100.00% <100.00%> (ø)
...r-slickgrid/services/groupingAndColspan.service.ts 100.00% <100.00%> (ø)
...dules/angular-slickgrid/services/shared.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d686ff...235c664. Read the comment docs.

@ghiscoding ghiscoding merged commit e24c6de into master Mar 2, 2021
@ghiscoding ghiscoding deleted the bugfix/frozen-column-reordered branch March 2, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant