-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING CHANGE: use Slickgrid-Universal monorepo next major 3.0 #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- to push for code reuse, let's use the Resizer Service from Slickgrid-Universal instead of a local copy
- for reusability and to stay DRY, let's use Footer Component from Slickgrid-Universal
Codecov Report
@@ Coverage Diff @@
## master #803 +/- ##
============================================
Coverage 100.00% 100.00%
============================================
Files 162 13 -149
Lines 11348 1075 -10273
Branches 4055 340 -3715
============================================
- Hits 11348 1075 -10273
Continue to review full report at Codecov.
|
ghiscoding
changed the title
WIP - BREAKING CHANGE: use Slickgrid-Universal monorepo
WIP - BREAKING CHANGE: use Slickgrid-Universal monorepo next major 3.x
Jul 12, 2021
ghiscoding
changed the title
WIP - BREAKING CHANGE: use Slickgrid-Universal monorepo next major 3.x
WIP - BREAKING CHANGE: use Slickgrid-Universal monorepo next major 3.0
Jul 12, 2021
- also use new export event names
ghiscoding
changed the title
WIP - BREAKING CHANGE: use Slickgrid-Universal monorepo next major 3.0
BREAKING CHANGE: use Slickgrid-Universal monorepo next major 3.0
Jul 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next Major Version
3.x
(WIP)This will be, for the most part, deleting a lot of code and instead use it from the Slickgrid-Universal lib to have 1 common/core lib. The advantage of that extra lib is that it's built as a monorepo and with that we'll be able to decouple a few Angular-Slickgrid Services (Export to File/Excel, OData, GraphQL, ...). So you will end up with a much smaller bundle since you will be bundling only what you really install and use (without having for example OData/GraphQL that you might never use).
On the migration side, it should be fairly simple following certain steps, the main changes are in regards to the Services that get decoupled, you can take a sneak peak at the changes in the upcoming Migration Guide
ETA 🤞 - Sometime in July or early August 🌞⛱️
Migration Guide
Minimum Requirement Changes
>= 12.1.0
>= 13.0.0
>= 4.3.5
7.2.0
(also amajor
bump)>= 4.5.0
(or any other UI framework like Bulma)List of TODOs
sg
prefix from all events in the global grid options and make sure all events still work($event.detail)
multiple-select.js
and use multiple-select-modified insteadyarn.lock
file into Git and also move from CircleCI to GitHub Actions3.x
@slickgrid-universal/excel-export
@slickgrid-universal/text-export
@slickgrid-universal/odata
@slickgrid-universal/graphql
master
branch intoversion2
branch to keep ref to older version2.x
version before rewriting to newer versionmain.ts
), check to see if we need to do that hereTODO
,@ts-ignore
and/or@deprecated
codelook at replacing Pagination Component with Slickgrid-Universal monorepo component packagecreateElement
) and that would be way too long to do, so I won't proceed with this oneremovedist
publish structure and use regular folder structureng-packagr
and how it then loads in Angularng-packgr
lib build still work