Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 4.3.0 is not supported for Angular 13 #994

Closed
5 tasks done
jsmnfaye opened this issue Aug 26, 2022 · 3 comments · Fixed by #997
Closed
5 tasks done

Version 4.3.0 is not supported for Angular 13 #994

jsmnfaye opened this issue Aug 26, 2022 · 3 comments · Fixed by #997
Labels

Comments

@jsmnfaye
Copy link

Describe the bug

Hello! I'm trying to upgrade to version 4.3.0 but it keeps asking me to upgrade to Angular 14. Based on your documentation, 4.x.x should work fine with Angular 13, which I have installed in my machine.

Reproduction

Have an Angular 13 project and try to install the latest Angular-Slickgrid library, which in this case is 4.3.0. You'll be notified that it requires Angular 14 to run.

Environment Info

Angular 13
Angular-Slickgrid 4.2.1
TypeScript ~4.5.5

Validations

@ghiscoding
Copy link
Owner

ghiscoding commented Aug 26, 2022

Yeah it was brought up in this Discussion #987, I didn't think and wasn't aware that upgrading the project itself to Angular 14 would also affect the minimal version for outside users but to my surprise it did. Unfortunately at this point I can't rollback, it's just too late, but you can use an older version 4.1.4 that was released before I upgraded internally to Angular 14 and it will work, you'll have to remove the ^ and also downgrade any Slickgrid-Universal packages to 1.2.6 if you have any installed

I think this should work, the OData is just an example, downgrade any Slickgrid-Universal to 1.2.6 if you have any

"angular-slickgrid": "4.1.4",
"@slickgrid-universal/odata": "1.2.6"

or you can even go up to Angular-Slickgrid 4.2.0 and Slickgrid-Universal 1.3.0 as shown in this Angular-Slickgrid-Demos commit which was the last one with Angular 13 again do this with fixed version without the ^ not even.

@ghiscoding ghiscoding pinned this issue Aug 28, 2022
ghiscoding-SE pushed a commit that referenced this issue Sep 12, 2022


- fixes #994
- we will update to newer version of Angular only on the next major version (which is currently in WIP) to avoid breaking users with Angular 13
ghiscoding-SE pushed a commit that referenced this issue Sep 12, 2022


- fixes #994
- we will downgrade to Angular 13 to avoid any breaking changes for users who are still using Angular 13
ghiscoding added a commit that referenced this issue Sep 12, 2022
fix(deps): downgrade to Angular 13 to avoid breaking changes, fixes #994
@ghiscoding
Copy link
Owner

ghiscoding commented Sep 12, 2022

decided to downgrade it back to Angular 13, so this issue should be fixed now. I'll upgrade back to 14 or 15 for the next major version which is currently in progress and is coming soon. see latest v4.3.1 release

@ghiscoding ghiscoding unpinned this issue Sep 13, 2022
@jsmnfaye
Copy link
Author

Thanks a lot! Appreciate the work that you do for this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants