WIP - feat: filter for lerna tags in independent mode #222
Conversation
Codecov Report
@@ Coverage Diff @@
## main #222 +/- ##
==========================================
+ Coverage 93.25% 93.26% +0.01%
==========================================
Files 134 134
Lines 3968 3987 +19
Branches 804 812 +8
==========================================
+ Hits 3700 3718 +18
- Misses 268 269 +1
Continue to review full report at Codecov.
|
| @@ -1,5 +1,5 @@ | |||
| import log from 'npmlog'; | |||
| import { ExecOpts, UpdateCollectorOptions } from '../../models'; | |||
| import {DescribeRefOptions, ExecOpts, UpdateCollectorOptions} from '../../models'; | |||
There was a problem hiding this comment.
are you using VSCode? I would assume that Prettier would add spaces around curly braces here, that is if you have the Prettier VSCode extension installed, if not please add spaces on both end of import
|
|
||
| const graph = buildGraph(); | ||
| const pkgs = graph.rawPackageList; | ||
| const execOpts = { cwd: "/test", match: '*@*'}; |
There was a problem hiding this comment.
can you provide an example of a tag with this pattern match *@*? I mean what would a typical tag look like for this? Might be better to add a unit test with such example!?
There was a problem hiding this comment.
All tags tagged by lerna follow @wundergraph/sdk@0.92.6 in independent mode.
There was a problem hiding this comment.
Might be better to add a unit test with such example!?
Yes, let me check.
|
@StarpTech hello, I'm back home, are you expecting to update the PR with what was identified in the review? or should I publish a patch release with the other changes you were waiting for? Also in the description of this PR, you mentioned that it fixes #200 but I think you meant that it fixes #220 instead, isn't it? |
|
@StarpTech hi there, not sure if you saw my last comment but I'm basically waiting for code change and feedback from your side to go further |
|
Hi @ghiscoding, I'm going to address the feedback in the next days. |
|
Quick update, it will take a bit longer. |
|
@StarpTech do you have a possible ETA to finish this PR fix? If it's within a week then I can wait, or else I can merge all my other PRs and make a new release without your PR but by doing it might (possibly will) bring possible conflicts in your PR which I was trying to avoid. EDIT adding WIP prefix so I don't merge it accidently |
ghiscoding
changed the title
|
@StarpTech |
|
Superseded by PR #267 which got merged (by assuming that this PR was ok as it was originally created), since no feedback was provided for the past few weeks |
Fix #220
Description
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: