Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter for lerna tags in independent mode #267

Merged
merged 4 commits into from Jul 20, 2022

Conversation

ghiscoding
Copy link
Member

@ghiscoding ghiscoding commented Jul 20, 2022

Description

Supersede PR #222 since no feedback were provided from the original PR author for nearly a month and I wish to advance and merge the PR. I can only assume, since no feedback provided, that the PR was ok as it was apart from the merge conflict and Prettier formatting which is why PR supersede the original PR.

Motivation and Context

The motivation is to advance and merge PR #222 that was opened for a month, it should fix issue #220

How Has This Been Tested?

unit tests were added and came from the original PR #222

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #267 (c1ebd4a) into main (c9d37f4) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
+ Coverage   93.79%   93.82%   +0.03%     
==========================================
  Files         142      142              
  Lines        4071     4089      +18     
  Branches      829      837       +8     
==========================================
+ Hits         3818     3836      +18     
  Misses        253      253              
Impacted Files Coverage Δ
.../core/src/utils/collect-updates/collect-updates.ts 98.08% <100.00%> (+0.17%) ⬆️
...ges/core/src/utils/collect-updates/lib/has-tags.ts 100.00% <100.00%> (ø)
packages/core/src/utils/describe-ref.ts 100.00% <100.00%> (ø)
packages/exec/src/exec-command.ts 100.00% <100.00%> (ø)
packages/list/src/list-command.ts 100.00% <100.00%> (ø)
packages/publish/src/publish-command.ts 96.89% <100.00%> (+0.01%) ⬆️
packages/run/src/run-command.ts 95.35% <100.00%> (+0.03%) ⬆️
packages/version/src/version-command.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9d37f4...c1ebd4a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants