Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): ensure to touch all nodes in package-graph, fix issue found by Jest team #301

Merged
merged 1 commit into from Aug 6, 2022

Conversation

ghiscoding
Copy link
Member

@ghiscoding ghiscoding commented Aug 6, 2022

Description

A previous PR introduced a way to "drastically reduce time taken to check for cycles" BUT had a very negative side effect reported by the Jest team here that caused a lot of packages to not be updated when they should have and not be published on npm when they should have. This PR fixes this issue by replicating a proposed solution in this Lerna PR 3234

Motivation and Context

The new issue reported by the Jest team was introduced by a previous PR #7 which had a negative side effect and caused a lot of packages to not be updated before publish (only 5 were updated when it should have been 43).

How Has This Been Tested?

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Aug 6, 2022

Codecov Report

Merging #301 (f4f7bbc) into main (29a76bb) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
+ Coverage   96.14%   96.14%   +0.01%     
==========================================
  Files         145      145              
  Lines        4220     4221       +1     
  Branches      882      882              
==========================================
+ Hits         4057     4058       +1     
  Misses        163      163              
Impacted Files Coverage Δ
packages/core/src/package-graph/package-graph.ts 100.00% <100.00%> (ø)
packages/diff/src/diff-command.ts 100.00% <100.00%> (ø)
packages/publish/src/publish-command.ts 99.01% <100.00%> (ø)
packages/version/src/version-command.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit 3ae2feb into main Aug 6, 2022
@ghiscoding ghiscoding deleted the bugfix/package-graph-touched-node branch August 6, 2022 21:49
@ghiscoding ghiscoding changed the title fix(core): ensure to touch all nodes in package-graph fix(core): ensure to touch all nodes in package-graph, fix issue found by Jest team Aug 7, 2022
@ghiscoding ghiscoding mentioned this pull request Aug 10, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant