Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong handling of independent mode? #324

Closed
5 tasks done
StarpTech opened this issue Aug 28, 2022 · 4 comments
Closed
5 tasks done

Wrong handling of independent mode? #324

StarpTech opened this issue Aug 28, 2022 · 4 comments
Labels
question Further information is requested stale-issue

Comments

@StarpTech
Copy link
Contributor

Describe the bug

Hi, I'm a bit curious about how the independent mode works. I made a preview and got the following logs:

> lerna version --conventional-commits --changelog-include-commits-client-login --create-release github --git-dry-run

lerna-lite notice cli v1.11.1
lerna-lite verb rootPath /home/starptech/repositories/wundergraph/wundergraph
lerna-lite info dry-run> git rev-parse
lerna-lite info versioning independent
lerna-lite verb project packages packages/nextjs packages/sdk packages/protobuf
lerna-lite info dry-run> git rev-list --count --all --max-count=1
lerna-lite verb isAnythingCommitted 1
lerna-lite verb currentBranch main
lerna-lite info dry-run> git show-ref --verify refs/remotes/origin/main
lerna-lite info dry-run> git remote update
lerna-lite info dry-run> git rev-list --left-right --count origin/main...main
lerna-lite verb hasTags filter for tags with '*@*' pattern
lerna-lite verb hasTags true
lerna-lite verb git-describe.sync "*@*" => "@wundergraph/nextjs@0.1.4-1-g9993f9a"
lerna-lite info Looking for changed packages since @wundergraph/nextjs@0.1.4
lerna-lite verb filtered diff packages/nextjs/package.json
lerna-lite verb filtered diff packages/protobuf/package.json
lerna-lite verb filtered diff packages/sdk/package.json
lerna-lite verb updated @wundergraph/nextjs
lerna-lite verb updated @wundergraph/protobuf
lerna-lite verb updated @wundergraph/sdk
lerna-lite info dry-run> git describe --always --long --dirty --first-parent
lerna-lite verb getChangelogConfig using preset "conventional-changelog-conventionalcommits"
lerna-lite verb getChangelogConfig Attempting to resolve preset "conventional-changelog-conventionalcommits"
lerna-lite info getChangelogConfig Successfully resolved preset "conventional-changelog-conventionalcommits"
lerna-lite verb independent increment 0.1.4 by patch - @wundergraph/nextjs
lerna-lite verb independent increment 0.91.2 by patch - @wundergraph/protobuf
lerna-lite verb independent increment 0.98.3 by patch - @wundergraph/sdk

Changes (3 packages):
 - @wundergraph/nextjs: 0.1.4 => 0.1.5
 - @wundergraph/protobuf: 0.91.2 => 0.91.3
 - @wundergraph/sdk: 0.98.3 => 0.98.4

Check the line

lerna-lite verb git-describe.sync "*@*" => "@wundergraph/nextjs@0.1.4-1-g9993f9a"
lerna-lite info Looking for changed packages since @wundergraph/nextjs@0.1.4

Shouldn't it be checked for each package individually? Why is @wundergraph/nextjs@0.1.4 the base?

Expectation

No response

Reproduction

No

Lerna config and logs

lerna.json

<!-- Please paste your `lerna.json` here -->

lerna-debug.log

<!-- If you have a `lerna-debug.log` available, please paste it here -->
<!-- Otherwise, feel free to delete this <details> block -->

Environment Info

| Executable        | Version |
| ----------------- | ------- |
| `lerna --version` | 1.11.1 |
| `npm --version`   | VERSION |
| `yarn --version`  | VERSION |
| `node --version`  | VERSION |

---
OR simply run `npx lerna info` command and copy+paste the result here

Used Package Manager

pnpm

Validations

@ghiscoding
Copy link
Member

I'm not really the person to ask for this since I never used it myself, I would suggest to search on the original Lerna project to see if you can answer to your question. I did however add the dry-run option and I think that portion is working as it should feel free to create PR if you find anything

@ghiscoding ghiscoding added question Further information is requested and removed pending triage labels Aug 28, 2022
@StarpTech
Copy link
Contributor Author

I'll look into it, but it would be great to have you on board. It sounds a bit odd to have it in core without any interest in making it work.

@z3dev
Copy link

z3dev commented Aug 28, 2022

@StarpTech the existing tags are really important when new versions are decided. You probably already know that, but just for completeness, can you supply the list of tags?

@github-actions
Copy link

This issue is considered Stale and will be automatically closed in 14 days unless more info is provided

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested stale-issue
Projects
None yet
Development

No branches or pull requests

3 participants