fix(deps): upgrading pacote & npm-packlist to v7 requires arborist tree #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `npm-packlist` has a breaking change, it now requires `tree` has the first parameter (see their [changelog](https://github.com/npm/npm-packlist/blob/main/CHANGELOG.md) - the arborist tree must now be provided in the options and will not be generated for you. the npm-packlist bin has also been removed. - also update Pacote to v14 which has a peerDep on npm-packlist v7 (see their [changelog](https://github.com/npm/pacote/blob/main/CHANGELOG.md))
ghiscoding
changed the title
Codecov Report
@@ Coverage Diff @@
## main #367 +/- ##
==========================================
+ Coverage 97.22% 97.25% +0.03%
==========================================
Files 145 145
Lines 4278 4277 -1
Branches 980 980
==========================================
Hits 4159 4159
+ Misses 119 118 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ghiscoding
changed the title
This was referenced Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
upgrade a few dependencies in the same PR since they are all related to each other
pacoteto v15npm-packlistv7 has a breaking change, it now requirestreehas the first parameternpm-registry-fetchto v14Motivation and Context
npm-packlist,npm-registry-fetchandpacotehave breaking changes that required code change in order to upgrade to their latest major version.How Has This Been Tested?
Types of changes
Checklist: