Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(commands): rename git-dry-run and cmd-dry-run to simply dry-run #377

Merged
merged 2 commits into from Oct 14, 2022

Conversation

ghiscoding
Copy link
Member

@ghiscoding ghiscoding commented Oct 13, 2022

Description

rename git-dry-run and cmd-dry-run to simply dry-run, the previous option names, when used, will display a warning in the logs.

Motivation and Context

cleanup options and rename the option to a simpler name dry-run and deprecate previous options names (they will be removed in next major version)

How Has This Been Tested?

update all unit tests

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #377 (fcfa4dc) into main (dc70df5) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #377      +/-   ##
==========================================
+ Coverage   97.22%   97.23%   +0.02%     
==========================================
  Files         145      145              
  Lines        4278     4295      +17     
  Branches      980      984       +4     
==========================================
+ Hits         4159     4176      +17     
  Misses        119      119              
Impacted Files Coverage Δ
packages/cli/src/cli-commands/cli-exec-commands.ts 100.00% <100.00%> (ø)
packages/cli/src/cli-commands/cli-run-commands.ts 100.00% <100.00%> (ø)
...kages/cli/src/cli-commands/cli-version-commands.ts 100.00% <100.00%> (ø)
packages/core/src/child-process.ts 100.00% <100.00%> (ø)
packages/core/src/command.ts 100.00% <100.00%> (ø)
packages/core/src/utils/check-working-tree.ts 94.74% <100.00%> (ø)
packages/core/src/utils/collect-uncommitted.ts 100.00% <100.00%> (ø)
.../core/src/utils/collect-updates/collect-updates.ts 98.08% <100.00%> (ø)
packages/core/src/utils/describe-ref.ts 100.00% <100.00%> (ø)
packages/exec/src/exec-command.ts 100.00% <100.00%> (ø)
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

- the deprecated option message will come from the version command since the publish command extend the version command cli
@ghiscoding ghiscoding merged commit 3a55f5e into main Oct 14, 2022
@ghiscoding ghiscoding deleted the feat/deprecate-git-dry-run branch October 14, 2022 19:43
Robbert added a commit to nl-design-system/themes that referenced this pull request May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant