Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump min Node version to >=14.17.0 to align with external deps #387

Merged
merged 1 commit into from Oct 14, 2022

Conversation

ghiscoding
Copy link
Member

@ghiscoding ghiscoding commented Oct 14, 2022

Description

bump Node min version from 14.15.0 to at least >=14.17.0 to align with recent dependencies upgrades like:

  • pacote, npm-registry-fetch, ssri, read-package-json, @npmcli/run-script, write-file-atomic and npmlog

Motivation and Context

to stay compatible with recent external dependencies upgrades

How Has This Been Tested?

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #387 (c821584) into main (8c34a3b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #387   +/-   ##
=======================================
  Coverage   97.25%   97.25%           
=======================================
  Files         145      145           
  Lines        4277     4277           
  Branches      980      980           
=======================================
  Hits         4159     4159           
  Misses        118      118           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit 2f804e9 into main Oct 14, 2022
@ghiscoding ghiscoding deleted the bugfix/bump-engine-npm branch October 14, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant