Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): libnpmaccess was rewritten, lsPackages is now getPackages #401

Merged
merged 1 commit into from Oct 21, 2022

Conversation

ghiscoding
Copy link
Member

@ghiscoding ghiscoding commented Oct 21, 2022

Description

The external lib libnpmaccess was rewritten to be more aligned with npm as per this commit (describe below) with their new release v7.x and we use 1 method from that lib which require an update on our side

feat(rewrite): Rewrite libnpmaccess
BREAKING CHANGE: the api for libnpmaccess is different now

It is aligned more with how npm uses it, consolidating the mfa functions into a
single command, and renames the functions to be easier to eventually
consolidate into a registry client library.

Motivation and Context

To keep Lerna-Lite up to date with dependencies, we have to do some changes since the external lib libnpmaccess was rewritten and the since method lsPackages() that we use was to renamed to getPackages(). It should be enough for our simple usage to just go with that simple change.

How Has This Been Tested?

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ghiscoding ghiscoding merged commit abb78b0 into main Oct 21, 2022
@ghiscoding ghiscoding deleted the bugfix/libnpmaccess-changes branch October 21, 2022 05:56
@ghiscoding ghiscoding added the dependencies Pull requests that update a dependency file label Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant