Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grouping): DraggableGrouping could throw when leaving page #1019

Merged
merged 1 commit into from Jul 1, 2023

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Jun 30, 2023

image

The error comes from SortableJS from this line
https://github.com/SortableJS/Sortable/blob/7af63fdc5d7512e7f0b8abb10970d473521b31a5/Sortable.js#L1115

image

- this fixes 2 issues identified in Angular-Slickgrid, ghiscoding/Angular-Slickgrid#1180
- when leaving a SPA page and going back to it, it could throw a bunch of errors. We simply need to make sure that any sortable instances are destroyed before recreating any new ones
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #1019 (2c2cba3) into master (30a0748) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1019   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          244       244           
  Lines        16558     16560    +2     
  Branches      5931      5931           
=========================================
+ Hits         16558     16560    +2     
Impacted Files Coverage Δ
...ages/common/src/extensions/extensionCommonUtils.ts 100.00% <100.00%> (ø)
...es/common/src/extensions/slickDraggableGrouping.ts 100.00% <100.00%> (ø)

@ghiscoding ghiscoding merged commit c233a9c into master Jul 1, 2023
5 checks passed
@ghiscoding ghiscoding deleted the bugfix/draggable-grouping-sortable-errors branch July 1, 2023 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant