Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins): RowMoveManager shouldn't add cssClass when not usable #1044

Merged
merged 2 commits into from Jul 20, 2023

Conversation

ghiscoding
Copy link
Owner

  • when usabilityOverride returns false on some rows, we shouldn't add the cssClass on the parent div

This issue came up in SlickGrid example while using an override function that returns false on every odd rows and it caused UI issue shown below

UI bug showing up

image

After fix

image

- when `usabilityOverride` returns false on some rows, we shouldn't add the `cssClass` on the parent div
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #1044 (8b35a9a) into master (c233a9c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1044   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          244       244           
  Lines        16560     16565    +5     
  Branches      5931      5936    +5     
=========================================
+ Hits         16560     16565    +5     
Impacted Files Coverage Δ
...kages/common/src/extensions/slickRowMoveManager.ts 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@ghiscoding ghiscoding merged commit f25eeec into master Jul 20, 2023
5 checks passed
@ghiscoding ghiscoding deleted the bugfix/row-move-manager-override-css branch July 20, 2023 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant