fix(common): Sort Service could throw on 3 clicks with undefined columnId #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixes issue found in Angular-Slickgrid ghiscoding/Angular-Slickgrid#1215 - when `multiColumnSort` is disabled, the 3rd clicks will not provide a sortCol object and was throwing an error for that reason, so use optional chaining to make sure it's defined before reading its sort column id
Codecov Report
@@ Coverage Diff @@
## master #1059 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 244 244
Lines 16564 16564
Branches 5933 5933
=========================================
Hits 16564 16564
|
5 tasks
ghiscoding
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multiColumnSortis disabled, the 3rd clicks will not provide a sortCol object and was throwing an error for that reason, so use optional chaining to make sure it's defined before reading its sort column id