Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pageUp/pageDown/home/end to SlickCellSelection #1126

Merged
merged 7 commits into from Oct 5, 2023

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Oct 4, 2023

  • adding "pageUp/pageDown/home/end" to SlickCellSelection when using selection with "Shift+{key}"
  • add new Example 19 demo to manually test updated Cell Selection feature w/wo Pagination

TODOs

  • tested manually, it should expect the following:
    • doing pageDown twice then pageUp once should equal to 1 pageDown
    • doing Shift+Home from anywhere should select all cells from current position to first row
    • doing Shift+End from should select all cells from current position to last row
    • using Pagination and doing Shift+{key} should select cells in current page only and not outside of it
  • add new Example to test Cell Selection with Pagination as detailed above
  • add full unit test coverage
  • add Cypress E2E tests

basic SlickGrid example

brave_jXaDZf7bB1

with DataView & Pagination example

brave_LARcl6SVGz

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #1126 (2fb523e) into master (82ba377) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1126   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          245       245           
  Lines        16847     16887   +40     
  Branches      6045      6063   +18     
=========================================
+ Hits         16847     16887   +40     
Files Coverage Δ
...s/common/src/extensions/slickCellSelectionModel.ts 100.00% <100.00%> (ø)

@ghiscoding ghiscoding changed the title WIP - feat: add pageUp/pageDown/home/end to SlickCellSelection feat: add pageUp/pageDown/home/end to SlickCellSelection Oct 5, 2023
@ghiscoding ghiscoding merged commit b7e9e0d into master Oct 5, 2023
5 checks passed
@ghiscoding ghiscoding deleted the feat/cell-selection-page-selection branch October 5, 2023 02:35
ghiscoding added a commit to ghiscoding/aurelia-slickgrid that referenced this pull request Oct 5, 2023
- update to latest Slickgrid-Universal v3.3.0 which gives access to this feature and other fixes
- Slickgrid-Universal PRs [1126](ghiscoding/slickgrid-universal#1126)
ghiscoding added a commit to ghiscoding/slickgrid-react that referenced this pull request Oct 5, 2023
- update to latest Slickgrid-Universal v3.3.0 which gives access to this feature and other fixes
- Slickgrid-Universal PRs [1126](ghiscoding/slickgrid-universal#1126)
ghiscoding added a commit to ghiscoding/aurelia-slickgrid that referenced this pull request Oct 5, 2023
- update to latest Slickgrid-Universal v3.3.0 which gives access to this feature and other fixes
- Slickgrid-Universal PRs [1126](ghiscoding/slickgrid-universal#1126)
ghiscoding added a commit to ghiscoding/slickgrid-react that referenced this pull request Oct 5, 2023
- update to latest Slickgrid-Universal v3.3.0 which gives access to this feature and other fixes
- Slickgrid-Universal PRs [1126](ghiscoding/slickgrid-universal#1126)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants