Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove CellRange, SlickRange, SlickGroup, ... unused interfaces #1219

Merged
merged 2 commits into from Nov 24, 2023

Conversation

ghiscoding
Copy link
Owner

  • since we moved SlickGrid inside the project, we can now use the TS classes directly instead of relying on similar interfaces
  • also remove slick core re-export and replace it by exporting core folder

- since we moved SlickGrid inside the project, we can now use the TS classes directly instead of relying on similar interfaces
- also remove slick core re-export and replace it by exporting core folder
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d723856) 86.11% compared to head (c7e5786) 86.11%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1219   +/-   ##
=======================================
  Coverage   86.11%   86.11%           
=======================================
  Files         208      208           
  Lines       21239    21239           
  Branches     7063     7063           
=======================================
  Hits        18287    18287           
  Misses       2952     2952           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit a4cc469 into next Nov 24, 2023
5 checks passed
@ghiscoding ghiscoding deleted the bugfix/cell-range-interface-and-more branch November 24, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants