Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Formatters): add new Formatters.iconBoolean for icon w/truthy val #1228

Merged
merged 1 commit into from Nov 28, 2023

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Nov 28, 2023

  • this formatter is meant to be generic to display any icon the user want to display any type of icon on a boolean truthy value. It was created to replace the Formatters.checkmark which was too restrictive since it only worked with Font-Awesome 4 and only 1 assigned icon. The new formatter allows you to use any CSS class you want to use on a truthy value.
  • note that any of these values is considered falsy and will not show the icon: false, undefined, null, 0 or any negative number

- this formatter is meant to be generic to display any icon you want on a boolean truthy value. It was created to replace the `Formatters.checkmark` which is only working for users with Font-Awesome 4 and nothing else, basically this new formatter is a lot less restrictive and allows the user to use any CSS class name he wants to use.
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f94fb12) 100.00% compared to head (f0c741e) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1228   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          245       246    +1     
  Lines        17281     17293   +12     
  Branches      6250      6254    +4     
=========================================
+ Hits         17281     17293   +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 17ab965 into master Nov 28, 2023
5 checks passed
@ghiscoding ghiscoding deleted the feat/icon-boolean-formatter branch November 28, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant