Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RowDetail): sort change should collapse all Row Detail #1284

Merged
merged 4 commits into from Dec 24, 2023

Conversation

ghiscoding
Copy link
Owner

  • calling sort should collapse all Row Detail, however this was only true when triggered by clicking on column header menu, however it wasn't being triggered when called from Header Menu and Grid Menu (clear all sorting)

- calling sort should collapse all Row Detail, however this was only true when triggered by clicking on column header menu, however it wasn't being triggered when called from Header Menu and Grid Menu (clear all sorting)
Copy link

codecov bot commented Dec 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6b97b3d) 89.1% compared to head (07596a2) 89.1%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1284     +/-   ##
========================================
+ Coverage    89.1%   89.1%   +0.1%     
========================================
  Files         198     198             
  Lines       21340   21343      +3     
  Branches     7098    7100      +2     
========================================
+ Hits        18995   18998      +3     
  Misses       2345    2345             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 21f6031 into master Dec 24, 2023
5 checks passed
@ghiscoding ghiscoding deleted the bugfix/row-detail-onsort-header-menu branch December 24, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant