fix(core): DataView inlineFilters should allow ES6 arrow functions
#1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ghiscoding
commented
Jan 2, 2024
ghiscoding
commented
- the sample code below was not working prior to this PR
- the sample code below was not working prior to this PR
```ts
dataView = new SlickDataView({ inlineFilters: true });
dataView.setFilter((item, args) => item["percentComplete"] > args.percentCompleteThreshold);
```
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1304 +/- ##
========================================
+ Coverage 94.7% 94.7% +0.1%
========================================
Files 198 198
Lines 21317 21332 +15
Branches 7085 7092 +7
========================================
+ Hits 20185 20200 +15
Misses 1132 1132 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.