Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add grid & cell role for screen ready accessibility #1337

Merged
merged 1 commit into from Jan 16, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Jan 16, 2024

  • this PR replicates an old SlickGrid PR (except the focus which can cause other issues) Make SlickGrid more accessible. mleibman/SlickGrid#616
  • it also adds the tabIndex: -1 on the cell which was mentioned in the issue and it seems to work the same as Ag-Grid does, with keyboard navigation so it looks ok to me
  • fixes an issue on SlickGrid project, but maybe just partially, I'm not sure since I'm a newbie with these accessibility stuff and nobody wants to help much so... pushing this PR and closing the ref issue

- this PR replicates an old SlickGrid PR (except the focus which can cause other issues) mleibman/SlickGrid#616
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (454ce99) 98.6% compared to head (f30acac) 98.6%.

Files Patch % Lines
packages/common/src/core/slickGrid.ts 85.8% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1337     +/-   ##
========================================
- Coverage    98.6%   98.6%   -0.0%     
========================================
  Files         198     198             
  Lines       21281   21283      +2     
  Branches     7096    7097      +1     
========================================
+ Hits        20973   20974      +1     
- Misses        308     309      +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 7309fa8 into master Jan 16, 2024
4 of 5 checks passed
@ghiscoding ghiscoding deleted the chore/role-accessibility branch January 16, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants