fix: auto-resize not just grid but also headers for Salesforce tabs #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- when switching Tabs in Salesforce, SlickGrid has problem resizing properly, a prior auto-resize patch was put in place some time ago to call `resizeGrid()` for certain period, but with v3.0 and higher that didn't seem to be enough since the headers were not being resized properly, so let's resize them too by calling `grid.updateColumns()` in the same auto-resize function
- I don't care how long the body is but I do care about how long the PR title is (max 72)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1395 +/- ##
========================================
+ Coverage 99.8% 99.8% +0.1%
========================================
Files 199 199
Lines 21557 21559 +2
Branches 7203 6938 -265
========================================
+ Hits 21493 21495 +2
Misses 64 64 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resizeGrid()for certain period, but with v3.0 and higher that didn't seem to be enough since the headers were not being resized properly, so let's resize them too by callinggrid.updateColumns()in the same auto-resize function